- 03 May, 2021 2 commits
-
-
Nicholas Lundgaard authored
**Problem** I merged #18 a little too soon; It has 3 issues: 1. It doesn't handle comment lines between nested properties 2. It doesn't handle a blank (whitespace) after `=` in the nested property opener like the other forms of properties. 3. The test case was inserted in the wrong location in `eini_tests` module; it should have been in its own test function, and it should have had some error cases. **Solution** 1. Add support for comment lines in between nested properties. 2. Add support for blank after `=` in nested property opener. 3. Refactor and extend the tests for nested properties to cover more ground. **Known Issues** After I merged #18, I noticed this warning: ``` Compiled src/eini_lexer.xrl Parse action conflict scanning symbol blank in state 51: Reduce to properties_nested from property_nested (rule 28 at line 97) vs. shift to state 53, adding right sisters to property_nested. Conflict resolved in favor of shift. ``` It appears that the introduction of nesting has added some ambiguity to the grammar aroud the `blank`, and this change makes it a little worse: ``` Parse action conflict scanning symbol break in state 47: Reduce to single_value from blank (rule 44 at line 121) vs. shift to state 52, adding right sisters to blank. Conflict resolved in favor of shift. Parse action conflict scanning symbol blank in state 58: Reduce to properties_nested from property_nested (rule 30 at line 101) vs. shift to state 61, adding right sisters to property_nested. Conflict resolved in favor of shift. Parse action conflict scanning symbol comment in state 58: Reduce to properties_nested from property_nested (rule 30 at line 101) vs. shift to state 12, adding right sisters to property_nested. Conflict resolved in favor of shift. ``` Now there is some ambiguity around `comment` as well, and this appears to cause an issue parsing INI files with a comment line at the end of a block of nested properties when another (not-nested) key follows. I don't know if we should mark this as a known issue or not, but the trigger case is in a commented unit test in `eini_tests`.
-
Alexander Clouter authored
-
- 06 Feb, 2020 1 commit
-
-
IUnknown authored
-
- 02 Mar, 2019 1 commit
-
-
Nicholas Lundgaard authored
Resolves erlcloud/erlcloud#583
-
- 10 Oct, 2016 2 commits
-
-
Evgeny M authored
Encoding of source files in R17+ is utf8 by default, in R16 ascii, so utf8 strings removed from the tests altogether for compatiblity.
-
Nathaniel Waisbrot authored
-
- 08 Oct, 2016 1 commit
-
-
brigadier authored
-
- 07 Oct, 2016 1 commit
-
-
Nathaniel Waisbrot authored
Erlang 19.x should fix this, so we'll either want to keep the tests "fixed" like this for a long time or stop testing on Erlang 17 & 18.
-
- 21 Sep, 2016 1 commit
-
-
Nicholas Lundgaard authored
The dash should really be supported as a title/key part. It it a commonly used "spacer" in titles and keys, and AWS INI files already support it. Partially deals with accense/eini#2, but I have left spaces for another day—it is not clear what the policy should be here.
-
- 04 Oct, 2011 1 commit
-
-
Shunichi Shinohara authored
-
- 23 Aug, 2011 2 commits
-
-
Ryosuke Nakai authored
-
Ryosuke Nakai authored
Binary and filename take over function to register ets table.
-
- 17 Aug, 2011 1 commit
-
-
Shunichi Shinohara authored
This fix bug of line number error. Thanks to @Hexa.
-
- 09 Aug, 2011 2 commits
-
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
- 03 Jun, 2011 1 commit
-
-
Shunichi Shinohara authored
-
- 31 May, 2011 3 commits
-
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
- 30 May, 2011 5 commits
-
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
- 27 May, 2011 1 commit
-
-
Shunichi Shinohara authored
-
- 25 May, 2011 2 commits
-
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
- 23 May, 2011 2 commits
-
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
- 21 May, 2011 6 commits
-
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-
- 19 May, 2011 2 commits
-
-
Shunichi Shinohara authored
-
Shunichi Shinohara authored
-